Conversation
…y precision as_millis() truncated sub-ms RTTs to 0.0, causing the display layer to show '—' (no measurement) for low-latency links. Switch Ping/Pong timestamps to microseconds so RTTs down to 1µs are preserved; latency_ms is now computed as (now_us - pong.timestamp_us) / 1000.0. Field number unchanged — wire-compatible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
copy_bidirectional_with_sizes returns exact byte counts but they were discarded, leaving bytes_in/bytes_out at zero for all TCP sessions. Pass SharedMetrics into run_tcp_session and increment after copy completes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Ping description no longer advertises unimplemented peer ping. Hint descriptions explain the auto-negotiation model. Disconnect description clarifies that peers may auto-reconnect after being dropped. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… the peer When a user adds a route pointing at a peer that advertises auto-managed routes (from its handshake), but none of those routes cover the requested CIDR, the route is silently accepted yet traffic will never reach its destination. This commit makes the gap visible across all interfaces: - IPC layer logs a tracing::warn and returns the warning in OkResponse.warning - REPL/CLI prints the warning to stderr after "OK" - MCP tool appends it to the success text - REST API includes it in the SuccessResponse.message field If the peer has no auto-managed routes (e.g. explicit-mode peers that don't advertise routes), no warning is issued. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ate deps Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maxholman
force-pushed
the
refactor/remove-ping
branch
from
2a1c672 to
d4c12c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0msand shows—statsnow reports non-zero bytes after tunnel trafficpingcommand —infoprovides the same data; peer ping was never implementedHow to verify
wallhack peers— latency shows fractional ms (e.g.0.3ms)wgetthrough tunnel, thenwallhack stats— bytes_in/bytes_out non-zerowallhack route add 10.99.99.0/24 gateway-perimeter— should warn about unadvertised CIDRwallhack pingno longer exists in CLI/REPL/MCP/RESTcargo test -q— all tests pass🤖 Generated with Claude Code